Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
fivenp authored Oct 2, 2019
1 parent 3c87cb3 commit af376af
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ You see... sky is the limit... Want to contribute? We'd love to see you helping

## Wait... but you you said it's bad?

Of course it's bad... You should **never** conduct a review and ignore the tests – which might be the most crucial part of your system! In some cases it makes complete sense tho.
Of course it's bad... You should **never** conduct a review and ignore the tests – which might be the most crucial part of your system!

To sum it up:
**Only try this approach at home if you know what you're doing**
Expand All @@ -37,4 +37,16 @@ To sum it up:

Reviews in general are a crucial and fundamental part of your job! Whenever a review is shorter than 10 minutes (or 2 hours if it's a big change) you should ask yourself whether you paid the requester enough respect and whether you're doing your job the right way!

....
We'd like you to stop reading, shut down your computer, start breathing for a minute and think about your profession. :)

Tests are the core of your code. They help you maintain functionality and deliver quality.

We know it's hard to review **7.000 changed lines and 200 changed files**. We know it's hard to keep track of everything a review requires. We can only encourage you to think twice before you start skipping reviewing the core of your code!

## Why all of this?

We wanted to highlight the **importance of high quality Reviews** and how easy we tend to forget about it.

To be very honest – we use `ignoreTheTests()` from time to time. But we're **very aware** of it! Our main job over here is UI/UX Design & Development – not functional API code. You see... it all depends on the **context when taking decisions**.

Dont forget yours!

0 comments on commit af376af

Please sign in to comment.