Add force branch name settings #519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It forces the usage of git review branch name by default, even with local branches It helps the classic workflow to always push on master, other branches are exceptional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One main idea of Gerrit's flow is to push on master, with custom git behaviours.
Thus on remote, it is very exceptional to work on another branch.
But locally, it still makes sense to use branches and to push on master.
Especially allows for a nice presentation on Gerrit with the "pushed together commits"
That's why it makes sense for the plugin to force the main branch based on the gitreview file.
But it only covers the case of a single local repo/gerritPushTargetPanel.
For multiple ones, we must type "master" in the branch input each time we push using a local branch.
It happens very often in my case.
Given I'm not sure everyone wants that behaviour (and I tried to understand the codebase), I've added a specific setting