Adding "Reset to here" action in patch set context menu #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwolfer
reviewed
Jul 15, 2021
src/main/java/com/urswolfer/intellij/plugin/gerrit/git/GerritGitUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/urswolfer/intellij/plugin/gerrit/git/GerritGitUtil.java
Show resolved
Hide resolved
src/main/java/com/urswolfer/intellij/plugin/gerrit/ui/action/ResetAction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/urswolfer/intellij/plugin/gerrit/ui/action/ResetAction.java
Outdated
Show resolved
Hide resolved
|
@brownian-motion: Do you think you will find the time to implement my comments? |
|
Hello, and thanks for looking at this PR so closely! I apologize for taking so long to reply @uwolfer . I'd be happy to implement these changes, and will submit a new commit soon! |
uwolfer
requested changes
Sep 21, 2021
| @@ -426,6 +427,18 @@ public GitLineHandler compute() { | |||
| } | |||
| } | |||
|
|
|||
| public Optional<VcsFullCommitDetails> loadGitCommitInfo(Project project, GitRepository gitRepository, ChangeInfo changeInfo) throws VcsException { | |||
| List<GitCommit> history = GitHistoryUtils.history(project, gitRepository.getRoot(), changeInfo.id); | |||
There was a problem hiding this comment.
changeInfo.id does not work in my case, it is not a git commit hash.
You can take a look at gerritUtil.getFirstFetchInfo(changeDetails);
| @@ -426,6 +427,18 @@ public GitLineHandler compute() { | |||
| } | |||
| } | |||
|
|
|||
| public Optional<VcsFullCommitDetails> loadGitCommitInfo(Project project, GitRepository gitRepository, ChangeInfo changeInfo) throws VcsException { | |||
| List<GitCommit> history = GitHistoryUtils.history(project, gitRepository.getRoot(), changeInfo.id); | |||
| if (history.isEmpty()){ | |||
There was a problem hiding this comment.
Please add a space before { (here and in other new code places).
|
@brownian-motion: Do you plan to update this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.