Fix #328 checkout to wrong folder using submodules #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwolfer
reviewed
Oct 23, 2018
| return Optional.of(repository); | ||
| } | ||
| } | ||
| if (repository.getRoot().getCanonicalPath().equals(project.getBaseDir().getCanonicalPath())) { |
There was a problem hiding this comment.
I think this solution looks a bit too simple to be true :)
Are you really sure that the code above is not required anymore?
|
To be honest: no :( It's seems for me, that Intellij doesn't support git submodules (see https://youtrack.jetbrains.com/issue/IDEA-64024). So Jetbrains's multi roots and git's submodules are similar but different. I recommend that I rewrite my commit to use it as a special but prefered case. Do you agree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #328: It works for me now.