Rebased onto latest develop #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a missing import to `modm_tools/bmp.py` - Changed `guess_serial_port()` to use `/dev/ttyBmpGdb` when guessing a BMP port
Remove deprecated statements
Co-authored-by: Niklas Hauser <[email protected]>
Co-authored-by: Niklas Hauser <[email protected]>
Co-authored-by: Christopher Durand <[email protected]>
Co-authored-by: Christopher Durand <[email protected]>
- modm::fiber -> modm::this_fiber. - modm::fiber::sleep() -> modm::this_fiber::sleep_for().
…cs#5) * [menu] Add optional allocator for ui menu classes, used for destroying AbstractViews * [menu] remove coupling between modm gui and modm menu view and menu This is because the gui stuff requires colored menus but the menu code should not have to have colored menus. This wouldn't be an issue if we could dynamic cast but on certain devices you can't do this.
When pulling from upstream develop, AllocatorBase has been moved to utils/allocator.hpp. This commit simply re-introduces safe fail behavior into AllocatorBase.construct and AllocatorBase.destroy that was previously added by Matthew Arnold (see 3ed0768 for more details).
…cs#5) * [menu] Add optional allocator for ui menu classes, used for destroying AbstractViews * [menu] remove coupling between modm gui and modm menu view and menu This is because the gui stuff requires colored menus but the menu code should not have to have colored menus. This wouldn't be an issue if we could dynamic cast but on certain devices you can't do this.
…cs#5) * [menu] Add optional allocator for ui menu classes, used for destroying AbstractViews * [menu] remove coupling between modm gui and modm menu view and menu This is because the gui stuff requires colored menus but the menu code should not have to have colored menus. This wouldn't be an issue if we could dynamic cast but on certain devices you can't do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are issues with the UART (which we should test, use this branch instead: aruw-master-2024q1).
This PR should not be merged in, but should be the new start point for the rebase this repository is.