Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable starting with python -m vitables #80

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Enable starting with python -m vitables #80

merged 1 commit into from
Sep 7, 2017

Conversation

mivade
Copy link
Contributor

@mivade mivade commented Sep 6, 2017

This is motivated by the vitables command seemingly not working on Windows, and it's easier to to do python -m vitables than have to remember that it should be python -m vitables.start.

@uvemas
Copy link
Owner

uvemas commented Sep 7, 2017

That is strange. The command works fine on my Windows 10 box. But I'll merge anyway.

@uvemas uvemas merged commit b5b4314 into uvemas:master Sep 7, 2017
@mivade mivade deleted the dunder_main branch September 29, 2017 13:46
@ankostis
Copy link
Contributor

The problem on Windows is that you don't see any broken dependencies that prevent it from starting.
For example on my machine, i'm getting a DLL error when loading numexpr, but logging is hidden when launched through gui_scripts setuptools entrypoint.

In general i ha dnever had a good experience with the gui_scripts (e.g. STDIN/STDOUT are missing and exceptions raised when accessed are simply lost).

So maybe use 'console_scripts' instead?
Should i open a new PR for that?

@uvemas
Copy link
Owner

uvemas commented Dec 13, 2018

Please, proceed with the PR if you want and I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants