Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #122

Merged
merged 4 commits into from
Jul 29, 2023
Merged

Update README #122

merged 4 commits into from
Jul 29, 2023

Conversation

DeeliN221
Copy link
Contributor

For issue #121

  • Change .txt to .rst
  • Add badges
  • Add screenshots to show how vitables looks like.

This is just a draft, feel free to revise.

Cheers 🍻

Zhilin Zheng and others added 3 commits July 20, 2023 10:41
temp save, continue to work on VScode
Hide many screenshots for simplicity
@uvemas
Copy link
Owner

uvemas commented Jul 20, 2023

Looks great! In my opinion the header (logo + badges + logo) is too large, but it is a matter of taste. So do it as you prefer.

CU!

@ankostis
Copy link
Contributor

What's the point of the FAQ suggested fix?
I mean, why not fix the code in the first place?

@DeeliN221
Copy link
Contributor Author

What's the point of the FAQ suggested fix? I mean, why not fix the code in the first place?

Feel free to add more questions and answers, I only wrote one in this draft. If you prefer, we could get rid of FAQ for this version.

@DeeliN221
Copy link
Contributor Author

Looks great! In my opinion the header (logo + badges + logo) is too large, but it is a matter of taste. So do it as you prefer.

CU!

Hi @uvemas, I saw the first logo (the larger one) in doc/images, and the second one in vitables.org. I like them both, but it may be a good idea to select ONLY one. Again, feel free to revise the draft.

Based on the comments
@uvemas
Copy link
Owner

uvemas commented Jul 25, 2023

@ankostis the problem was fixed in the repo some time ago but I haven't released new versions since Dec. 2019. I'm in the process of publishing the new minor release ASAP. So if @m3lab-zzl removes the mention to Iterable the document will be just fine IMHO.

@uvemas uvemas merged commit 074a259 into uvemas:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants