Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 3986 azure blob storage adapter implementation #81

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Feat 3986 azure blob storage adapter implementation #81

wants to merge 45 commits into from

Conversation

jamesrcramos
Copy link

Co-authored by @ArtP1 and @softTam

What does this PR do?

This PR integrates Microsoft's Azure Blob storage adapter into the storage repo. This completes phase 1 of 2 of implementing a new storage adapter.

Test Plan

We utilized the provided command vendor/bin/phpunit --configuration phpunit.xml to run unit tests we curated for the Azure storage ecosystem.
image

Related PRs and Issues

🗄️ Extend Appwrite Storage with Azure Blob Storage Adapter #3986

ArtP1 and others added 30 commits July 17, 2023 03:50
@ArtP1
Phase 1 Setup: new device adapter starter code
94b3aef 
* Added new storage adapter file 'src/Storage/Device/AzureBlob.php'
* Introduced new device constant on file 'src/Storage/Storage/Storage.php'
* Added new device adapter test file 'tests/Storage/Device/AzureBlobTest.php'
@softTam
Fixed syntax error with declaring namespace
375665e
@softTam
Added sample code for __construct and init
5e1d8d8
@softTam
Fixed concatenation error
e19bfbc
@jamesrcramos
Commented out files uneeded for current objective/issue due to test c…
445d8bf 
…ommand conflicts
@jamesrcramos
Merged codebase due to conflicts
7005b1a
@jamesrcramos
Uncommented S3, removed irrelevant import statements, AzureBlob now e…
6c84204 
…xtends S3 again
@jamesrcramos
Uncommented important construct call
66e8aaf
@jamesrcramos
Reverted extension to Device and rewrote constructor function
0b6483d
@jamesrcramos
Initialized constants and introduced functions from S3 file
30653fd
@jamesrcramos
Marked which functions are completed or not with comments
cb1a2ee
@jamesrcramos
Rewrote S3's call function to provide a general base for Azure's spec…
4a45c6d 
…ifications
@softTam
Added getAuthorizationHeader and other helper functions
0ba4021
@softTam
Added azureHeaders variables
e937f04
@softTam
Finished the call and getAuthorizationHeader functions. Added more co…
b977fed 
…mments.
@softTam
Modified the list of private variables. Updated function upload and i…
65607ab 
…ts helper functions
@jamesrcramos
Completed editing 'abort' function
15f1883
@jamesrcramos
Revised 'delete' function
f78e5a5
@jamesrcramos
Commented out getSignatureV4
54bc7f8
@ArtP1
Possible read function for azure blob storage device
014b242
@softTam
Finished the upload and helper functions
b2951ba
@softTam
Modified getInfo function. Added comments to clarify which functions …
245cda3 
…are done
@jamesrcramos
Corrected HTTP method of abort function
d6cda6d
@jamesrcramos
Merge branch 'feat-3986-AzureBlob-storage-adapter' of https://github.…
66d76ad 
…com/jamesrcramos/storage into feat-3986-AzureBlob-storage-adapter
@jamesrcramos
Created pseudocode implementation steps for 'deletePath' function
d1b1494
@softTam
Edited some comments.
2975e3a
@softTam
Added the listBlobs function
f6daa33
@jamesrcramos
Revised psuedocode for deletePath function, removed incorrect impleme…
853bc59 
…ntation of S3 deletePath implementation
@jamesrcramos
Implemented inner part of deletePath; still need to incorporate do-wh…
be67df7 
…ile loop
@softTam
Fixed syntax error in constructor. Edited test file.
5b129fa
softTam and others added 15 commits August 4, 2023 00:46
@softTam
Added code to parse blob names from an XML array
403c4c2
@jamesrcramos
Completed 'deletePath' function by incorporating delete loop
4778544
@softTam
Reviewed and edited upload(), abort(), and write() functions.
3673eda
@softTam
Fixed a small error in deletePath function
6adec9a
@jamesrcramos
Removed unecessary + irrelevant comments and functions from code
b48cbb3
@softTam
Edited getAuthorizationHeader function and its help functions.
d3455ed
@softTam
Fixed fail to authenticate error. Same error still exists for very fe…
ad3660c 
…w requests.
@softTam
Removed x-ms-delete-snapshots error. Reduced the number of testing er…
defc7ec 
…rors from 21 to 3.
@softTam
Fixed header errors in AzureBlob.php. Modified assertions in testFile…
ff5caee 
…Hash() function in AzureBlobTest.php.
@softTam
Fixed the code that caused an exception when calling deletePath() fun…
5ab8aee 
…ction.
@softTam
Fixed all bugs. Passed all tests.
edc31bf
@softTam
Deleted unnecessary comments and added documentation comments to all …
cfb7446 
…functions.
@softTam
Finalized everything regarding Azure. Need to uncomment all files bef…
85883b2 
…ore submitting a PR.
@jamesrcramos
Uncommented commented-out files to revert them to their runnable states
0c0b0e9
@jamesrcramos
Removed leftover comment used to test a function
efbf11e
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
@stnguyen90 stnguyen90 self-requested a review October 31, 2023 23:59
stnguyen90
stnguyen90 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesrcramos @stnguyen90 @ArtP1 @softTam