Added RollBar Logger Changes #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christyjacob4 Please review this once |
4 tasks
|
|
|
Successful test: 
{
"body": {
"timestamp": 1690241898,
"message": {
"body": "Document efgh5678 not found"
}
},
"uuid": "7a49f3c1bb014cfc8e32bcdcbc78ce46",
"level": "error",
"timestamp": 1690241898,
"custom": [
"sdk: Flutter",
"sdkVersion: 0.0.1",
"authMode: default",
"authMethod: cookie",
"authProvider: MagicLink",
"type: error",
"environment: production",
"sdk: utopia-logger/0.1.0"
],
"environment": "production",
"framework": "unknown",
"trace_chain": [
{
"category": "http",
"message": "DELETE /api/v1/database/abcd1234/efgh5678",
"type": "default",
"level": "debug"
},
{
"category": "auth",
"message": "Using API key",
"type": "default",
"level": "debug"
},
{
"category": "auth",
"message": "Authenticated with * Using API Key",
"type": "default",
"level": "info"
},
{
"category": "database",
"message": "Found collection abcd1234",
"type": "default",
"level": "info"
},
{
"category": "database",
"message": "Permission for collection abcd1234 met",
"type": "default",
"level": "debug"
},
{
"category": "database",
"message": "Missing document when searching by ID!",
"type": "default",
"level": "error"
}
],
"metadata": {}
} |
|
example with proper stack trace: 
{
"body": {
"trace": {
"frames": [
{
"method": "include",
"args": [
"/workspace/logger/vendor/phpunit/phpunit/phpunit"
],
"lineno": 122,
"filename": "/workspace/logger/vendor/bin/phpunit"
},
{
"method": "PHPUnit\\TextUI\\Command::main",
"args": [],
"lineno": 107,
"filename": "/workspace/logger/vendor/phpunit/phpunit/phpunit"
},
{
"method": "PHPUnit\\TextUI\\Command::run",
"args": [
[
"vendor/bin/phpunit",
"--configuration",
"phpunit.xml",
"tests"
],
true
],
"lineno": 97,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/TextUI/Command.php"
},
{
"method": "PHPUnit\\TextUI\\TestRunner::run",
"args": [
{
"class": "PHPUnit\\Framework\\TestSuite",
"value": [
{
"class": "PHPUnit\\Framework\\TestSuite",
"value": [
{
"class": "LoggerTest",
"value": []
},
{
"class": "LoggerTest",
"value": []
},
{
"class": "LoggerTest",
"value": []
},
{
"class": "LoggerTest",
"value": []
}
]
}
]
},
{
"registerMockObjectsFromTestArgumentsRecursively": false,
"forceCoversAnnotation": false,
"verbose": false,
"convertDeprecationsToExceptions": false,
"executionOrderDefects": 0,
"failOnSkipped": false,
"beStrictAboutResourceUsageDuringSmallTests": false,
"stopOnFailure": false,
"disallowTodoAnnotatedTests": false,
"colors": "auto",
"stopOnRisky": false,
"listSuites": false,
"executionOrder": 0,
"convertNoticesToExceptions": true,
"stopOnError": false,
"failOnRisky": false,
"noInteraction": false,
"stopOnSkipped": false,
"processIsolation": false,
"enforceTimeLimit": false,
"backupGlobals": false,
"notLoadedExtensions": [],
"strictCoverage": false,
"reportLowUpperBound": 50,
"reverseList": false,
"resolveDependencies": true,
"testdoxExcludeGroups": [],
"randomOrderSeed": 1690242484,
"testdoxGroups": [],
"cacheResult": true,
"failOnEmptyTestSuite": false,
"columns": 80,
"crap4jThreshold": 30,
"cacheResultFile": "/workspace/logger",
"listGroups": false,
"repeat": false,
"stopOnDefect": false,
"listTests": false,
"warnings": [],
"groups": [],
"beStrictAboutChangesToGlobalState": false,
"timeoutForMediumTests": 10,
"useDefaultConfiguration": true,
"configurationObject": {
"class": "PHPUnit\\TextUI\\XmlConfiguration\\Configuration",
"value": []
},
"convertErrorsToExceptions": true,
"reportUselessTests": true,
"disableCodeCoverageIgnore": false,
"configuration": "phpunit.xml",
"stopOnWarning": false,
"unavailableExtensions": [],
"failOnWarning": false,
"loadedExtensions": [],
"stopOnIncomplete": false,
"defaultTimeLimit": 1,
"listTestsXml": false,
"failOnIncomplete": false,
"backupStaticAttributes": false,
"bootstrap": "./vendor/autoload.php",
"timeoutForSmallTests": 1,
"disallowTestOutput": false,
"testSuffixes": [
"Test.php",
".phpt"
],
"filter": false,
"reportHighLowerBound": 90,
"listeners": [],
"excludeGroups": [],
"extensions": [],
"stderr": false,
"debug": false,
"convertWarningsToExceptions": true,
"ignoreDeprecatedCodeUnitsFromCodeCoverage": false,
"reverseDefectList": false,
"timeoutForLargeTests": 60
},
[],
true
],
"lineno": 144,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/TextUI/Command.php"
},
{
"method": "PHPUnit\\Framework\\TestSuite::run",
"args": [
{
"class": "PHPUnit\\Framework\\TestResult",
"value": []
}
],
"lineno": 651,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/TextUI/TestRunner.php"
},
{
"method": "PHPUnit\\Framework\\TestSuite::run",
"args": [
{
"class": "PHPUnit\\Framework\\TestResult",
"value": []
}
],
"lineno": 684,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/Framework/TestSuite.php"
},
{
"method": "PHPUnit\\Framework\\TestCase::run",
"args": [
{
"class": "PHPUnit\\Framework\\TestResult",
"value": []
}
],
"lineno": 684,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/Framework/TestSuite.php"
},
{
"method": "PHPUnit\\Framework\\TestResult::run",
"args": [
{
"class": "LoggerTest",
"value": []
}
],
"lineno": 964,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/Framework/TestCase.php"
},
{
"method": "PHPUnit\\Framework\\TestCase::runBare",
"args": [],
"lineno": 728,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/Framework/TestResult.php"
},
{
"method": "PHPUnit\\Framework\\TestCase::runTest",
"args": [],
"lineno": 1214,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/Framework/TestCase.php"
},
{
"method": "LoggerTest::testAdapters",
"args": [],
"lineno": 1608,
"filename": "/workspace/logger/vendor/phpunit/phpunit/src/Framework/TestCase.php"
},
{
"lineno": 201,
"filename": "/workspace/logger/tests/LoggerTest.php"
}
],
"exception": {
"message": "test exception",
"class": "Exception"
}
}
},
"uuid": "1a71e944-02b4-457a-a02a-3f0d38b4f074",
"language": "php",
"level": "error",
"timestamp": 1690242484,
"code_version": "",
"request": {
"POST": [],
"GET": []
},
"server": {
"host": "55b92c98fe5a",
"argv": [
"vendor/bin/phpunit",
"--configuration",
"phpunit.xml",
"tests"
]
},
"environment": "production",
"platform": "Linux 55b92c98fe5a 6.1.27-060127-generic #202305051509 SMP PREEMPT_DYNAMIC Fri May 5 15:48:49 UTC 2023 x86_64",
"framework": "unknown",
"custom": [],
"notifier": {
"version": "3.1.2",
"name": "rollbar-php"
},
"metadata": {
"customer_timestamp": 1690242484
}
} |
stnguyen90
requested changes
Jul 24, 2023
stnguyen90
requested changes
Jul 26, 2023
stnguyen90
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
@christyjacob4, I think this is good to merge, but we need to add the TEST_ROLLBAR_KEY secret for the tests, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: appwrite/appwrite#4208