-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dynatrace Adaptor #21
base: main
Are you sure you want to change the base?
Conversation
@PineappleIOnic If you can add a |
Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃 |
@stnguyen90 I would greatly appreciate if you can review this PR. Please let me know if additional changes are needed. |
@michizhou looks like there are merge conflicts. Would you please resolve them? |
@stnguyen90 I have resolved the merge conflicts. Please let me know if additional changes are needed. |
@michizhou thanks a lot for your contributions during Hacktoberfest 2022! The PR will be merged after some more reviews. Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. |
$adapter = new Dynatrace(\getenv('TEST_DYNATRACE_KEY').';'.\getenv('TEST_DYNATRACE_ENV_ID')); | ||
$logger = new Logger($adapter); | ||
$response = $logger->addLog($log); | ||
$this->assertEquals(201, $response); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the test, but it failed. After outputting the response from dynatrace, I got:
{"error":{"code":400,"message":"Could not map JSON at \'properties.stacktrace\' near line 1 column 453"}}
Were you able to successfully push an event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stnguyen90 I don't recall pushing any events to Dynatrace, which is probably why I didn't catch this error. Do you know how we can resolve this issue? I'm willing to help in any way I can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michizhou, please refer to Dynatrace's docs and see how to properly pass the stacktrace.
Closes appwrite/appwrite#4210