Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dynatrace Adaptor #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

michizhou
Copy link

@michizhou
Copy link
Author

michizhou commented Nov 1, 2022

@PineappleIOnic If you can add a hacktoberfest-accepted label to this PR to ensure it counts towards my Hacktoberfest contributions count, I would greatly appreciate it!

@stnguyen90
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@michizhou
Copy link
Author

@stnguyen90 I would greatly appreciate if you can review this PR. Please let me know if additional changes are needed.

@stnguyen90
Copy link
Contributor

@michizhou looks like there are merge conflicts. Would you please resolve them?

@michizhou
Copy link
Author

@stnguyen90 I have resolved the merge conflicts. Please let me know if additional changes are needed.

@stnguyen90 stnguyen90 self-requested a review April 3, 2023 15:23
@christyjacob4
Copy link
Contributor

@michizhou thanks a lot for your contributions during Hacktoberfest 2022! The PR will be merged after some more reviews.

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

$adapter = new Dynatrace(\getenv('TEST_DYNATRACE_KEY').';'.\getenv('TEST_DYNATRACE_ENV_ID'));
$logger = new Logger($adapter);
$response = $logger->addLog($log);
$this->assertEquals(201, $response);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the test, but it failed. After outputting the response from dynatrace, I got:

{"error":{"code":400,"message":"Could not map JSON at \'properties.stacktrace\' near line 1 column 453"}}

Were you able to successfully push an event?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stnguyen90 I don't recall pushing any events to Dynatrace, which is probably why I didn't catch this error. Do you know how we can resolve this issue? I'm willing to help in any way I can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michizhou, please refer to Dynatrace's docs and see how to properly pass the stacktrace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚨 Improve Appwrite Logging with Dynatrace Adapter
3 participants