Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support BIGINT/LONG type #95

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Feat: support BIGINT/LONG type #95

merged 2 commits into from
Dec 29, 2021

Conversation

kodumbeats
Copy link
Contributor

@kodumbeats kodumbeats commented Dec 15, 2021

This PR adds support for BIGINT values, triggered when integer is created with $size >= 8. MongoDB shouldn't require any modifications, since it should transparently detect the LONG BSON type automatically.

Tests:
Tests have been added to check BIGINT/LONG support.

Related issues:
#94

Have you read the contribution guide?
Yes.

Refs:
https://mariadb.com/kb/en/bigint/
https://mariadb.com/kb/en/int/
https://mariadb.com/kb/en/data-type-storage-requirements/
https://docs.mongodb.com/manual/reference/bson-types/#bson-types

Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @kodumbeats 👍🏻

@TorstenDittmann TorstenDittmann merged commit 15515a7 into main Dec 29, 2021
@TorstenDittmann TorstenDittmann deleted the feat-bigint-support branch December 29, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants