Merge pull request #43 from utopia-php/update-mixpanel-adapter

feat: filter empty values before sending event
utopia-php · Mar 22, 2023 · 14c8051 · 14c8051
2 parents 70ada5e + ef16953
commit 14c8051
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Analytics/Adapter/Mixpanel.php b/src/Analytics/Adapter/Mixpanel.php
@@ -51,8 +51,16 @@ public function send(Event $event): bool
             'url' => $event->getUrl(),
         ];
 
+        $properties = array_filter($properties, function ($value) {
+            if (is_array($value)) {
+                return ! empty($value);
+            }
+
+            return ! is_null($value) && $value !== '';
+        });
+
         foreach ($event->getProps() as $key => $value) {
-            if (! isset($properties[$key])) {
+            if (! isset($properties[$key]) && ! is_null($value) && $value !== '' && ! empty($value)) {
                 $properties[$key] = $value;
             }
         }

diff --git a/tests/Analytics/AnalyticsTest.php b/tests/Analytics/AnalyticsTest.php
@@ -214,6 +214,9 @@ public function testMixpanel()
                 'custom_prop1' => 'custom_value1',
                 'custom_prop2' => 'custom_value2',
                 'custom_prop3' => 'custom_value3',
+                'custom_prop4' => '',
+                'custom_prop5' => null,
+                'custom_prop6' => [],
             ]);
 
         $this->assertTrue($this->mp->send($event));