DBIO: Enable reassignment of ownership of records #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dation: * when configured, build in people service into DBClient * when configured, use people service to validate user id given to reassign() * mds3: switch from using NSDClient to PeopleService (from DBClient) * move InvalidUpdate from dbio.project to dbio.base for use by reassign()
* DBIOHandler: add get_text_body() convenience method * fix minor doc typo in formats.py
application/x-www-form-urlencoded, which is default for python requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to allow changing the owner of a DBIO record through the web API. To validate the new user ID as valid and recognized, access to the people service is made available to the
dbio.DBClient. This is done via thePeopleServicewhich has a direct connection to the MongoDB collections (rather than through a web API). Themds3DAP service was updated to use this samePeopleServiceinstance (switching from theNSDClientwhich goes through the web API). To make use of the people service, the dbio configuration must include apeople_serviceparameter.When the ownership is changed to a new user, the service will also update the ACLs to give all permissions to the new user. The permissions for the old user are not removed.
As a convenience, the API was updated to allow clients to request and update the record's name and owner using a plain text (by setting the
Content-Typeheader totext/plain) instead of the default JSON format.To test, it is recommended to run under
oar-docker,MIDASbetabranch, setting the tag fordbioto this branch in thedeployment.ymlfile.