Merge pull request #235 from joshuaehill/iidReporting

Consistently run both the chi-square independence and chi-square goodness-of-fit tests
usnistgov · Jul 12, 2024 · 68ed165 · 68ed165
2 parents 8fadb3d + 6016199
commit 68ed165
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/cpp/iid/chi_square_tests.h b/cpp/iid/chi_square_tests.h
@@ -637,6 +637,7 @@ bool chi_square_tests(const uint8_t data[], const int sample_size, const int alp
 	double score = 0.0;
 	double pvalue;
 	int df = 0;
+	bool result = true;
 
 	// Chi Square independence test
 	if(alphabet_size == 2){
@@ -661,7 +662,7 @@ bool chi_square_tests(const uint8_t data[], const int sample_size, const int alp
 
 	// Check result to return if test failed
 	if(pvalue < 0.001){
-		return false;
+		result = false;
 	}
 
 	// Reset score and df
@@ -691,8 +692,8 @@ bool chi_square_tests(const uint8_t data[], const int sample_size, const int alp
 
 	// Check result to return if test failed
 	if(pvalue < 0.001){
-		return false;
+		result = false;
 	}
 
-	return true;
+	return result;
 }