Update test_SST1DBLoader.py by testing scan ID 87758 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a set of tests for scan ID 87758 to check that the loadRun function continues to work for a more recent scan and that it works for a case in which a single energy and two polarizations are run.
|
@PriyankaKetkarBNL if you look in the CI logs (below) you'll see that the new test is failing. This might be as simple as a problem with two tests having the same name - can you try changing that and see if it passes? |
Changed the names of the tests for scan ID 87758 so that they are different than the names of the tests for scan ID 21792
|
I just updated the test names. It seems like some of the checks are succeeding now, but still others are failing. I don't immediately follow where the issue is. |
|
The tests weren't running due to an old version merged in #132. The ones marked as succeeded were documentation and security analysis; the tests are in "PyHyperScattering CI Testing". I updated with main and tests should run again now. |
pbeaucage
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a set of tests for scan ID 87758 to check that the loadRun function continues to work for a more recent scan and that it works for a case in which a single energy and two polarizations are run.
See issue 154 for more details.