Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml build system and migrate versioneer to new build system. #151

Conversation

pbeaucage
Copy link
Collaborator

Fixes #149, pip install -e .[bluesky,ui] now installs the correct requirements.

Copy link
Collaborator

@martintb martintb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L(mostly)GTM

Consider the extra optional build sets that I mention. Willing to approve without these changes.

"numexpr<2.8.5",
]

[project.optional-dependencies]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three more optional dependency sets to consider
[doc] - sphinx, documentation building, etc
[test] - pytest, black, codecov, pylint, etc
[all] - union of everything

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion, done, thx!

Copy link
Collaborator

@martintb martintb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martintb martintb merged commit eae8b46 into main Sep 4, 2024
16 checks passed
@martintb martintb deleted the 149-requirementstxt-is-maybe-not-being-used-and-extras-are-definitely-not-being-used branch September 4, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requirements.txt is maybe not being used, and extras are definitely not being used
2 participants