-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml build system and migrate versioneer to new build system. #151
Switch to pyproject.toml build system and migrate versioneer to new build system. #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L(mostly)GTM
Consider the extra optional build sets that I mention. Willing to approve without these changes.
"numexpr<2.8.5", | ||
] | ||
|
||
[project.optional-dependencies] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three more optional dependency sets to consider
[doc] - sphinx, documentation building, etc
[test] - pytest, black, codecov, pylint, etc
[all] - union of everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion, done, thx!
…and-extras-are-definitely-not-being-used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #149,
pip install -e .[bluesky,ui]
now installs the correct requirements.