Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI hooks for SST1RSoXSDB testing #145

Merged
merged 14 commits into from
Sep 4, 2024
Merged

Conversation

pbeaucage
Copy link
Collaborator

@pbeaucage pbeaucage commented Sep 3, 2024

This PR adds machinery to enable online connections to the BNL Tiled server during testing. The 4 tests that run against SST1RSoXSDB now run in GitHub actions. More testing against other scans would be a good idea, and this machinery now supports that.

@pbeaucage pbeaucage linked an issue Sep 3, 2024 that may be closed by this pull request
@pbeaucage pbeaucage marked this pull request as ready for review September 3, 2024 21:51
Copy link
Collaborator

@EliotGann EliotGann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo

tests/test_SST1DBLoader.py Outdated Show resolved Hide resolved
tests/test_SST1DBLoader.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@EliotGann EliotGann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@pbeaucage pbeaucage merged commit 5c1662a into main Sep 4, 2024
16 checks passed
@pbeaucage pbeaucage deleted the 124-test-add-CI-for-SST1RSoXS branch September 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Add SST1RSoXSDB testing against public tiled server
2 participants