Adds custom field support to iOS app. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itude and latitude compare issue.
Conflicts: Classes/Controllers/IncidentAddViewController.m Classes/Models/Deployment.h Classes/Models/Incident.m Classes/Models/IncidentCustomField.h Classes/Models/IncidentCustomField.m
|
Hey Kunjan, thanks for the custom forms code! I've been quietly working behind the scenes on the new version of the app, which separates the data layer and synchronization into a standalone SDK. The good news is I finally pushed the new code base to GitHub. I'll take a look at your pull request and try to re-implement the custom forms using the new NSOperation technique. |
|
Thanks! There were a few bug fixes as well eg: 842f915 let me know if you have any questions on it. You will need to be on develop branch on the server side of things to have the json api for custom forms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these set of commits adds support for custom fields. Needs ushahidi/Ushahidi_Web#896 to work properly. Needs testing.