POC use ent as dbv2 #2940
Draft
POC use ent as dbv2 #2940
+8,496
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Zhang <[email protected]>
Signed-off-by: Wei Zhang <[email protected]>
Signed-off-by: Wei Zhang <[email protected]>
|
I mark it as draft, and we can discuss it here. the PR should actually work for API v2 to get memos. |
boojack
reviewed
Feb 19, 2024
| tempList, err := s.Store.ListMemoRelations(ctx, &store.FindMemoRelation{ | ||
| MemoID: &request.Id, | ||
| }) | ||
| tempList, err := s.Store.V2.MemoRelation. |
There was a problem hiding this comment.
Should we wrap a method in the store package?
There was a problem hiding this comment.
that's also my first try wrapping the db inside store.
but there are a few concerns, and we can discuss:
- using the origin store interface has no way to distinguish v1 or v2, we can only replace the origin v1 directly in each function step by step.
- it seems not worth creating a new store interface only for ent operations
- the ent client seems to be easy enough to use
|
Sorry for the late review. Overall, I think it is a good try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have divided the PR into 3 commits to show how ent could be used.