Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update go version, packages and github actions #236

Merged
merged 5 commits into from
Dec 4, 2023
Merged

chore: update go version, packages and github actions #236

merged 5 commits into from
Dec 4, 2023

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Sep 29, 2023 •
edited
Loading

This PR performs a few overdue maintenance tasks on the build-deploy-tool:

It:

  • Updates all the github actions to their most recent releases
  • Updates a few of the packages used in the build-deploy-image to more recent releases
  • Updates the version of golang to 1.21 (from 1.18)
  • Updates all the go packages (including renames, excluding pinned versions)

@shreddedbacon
Copy link
Member

shreddedbacon commented Oct 11, 2023 •
edited
Loading

This has a very messy diff nvm, needed to refresh it

shreddedbacon
shreddedbacon approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can remove the docker:24 bump from this, then all the go version changes are fine to merge

@shreddedbacon shreddedbacon changed the title Update image chore: update go version and github actions Nov 27, 2023
@shreddedbacon shreddedbacon added this to the v2.17 milestone Nov 27, 2023
@uselagoon uselagoon deleted a comment from github-actions bot Nov 27, 2023
@uselagoon uselagoon deleted a comment from github-actions bot Nov 27, 2023
@tobybellwood tobybellwood marked this pull request as ready for review November 27, 2023 08:00
@tobybellwood tobybellwood changed the title chore: update go version and github actions chore: update go version, packages and github actions Nov 27, 2023
shreddedbacon
shreddedbacon approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shreddedbacon shreddedbacon merged commit 1f514fc into main Dec 4, 2023
2 checks passed
@shreddedbacon shreddedbacon deleted the update_image branch December 4, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.17
Development

Successfully merging this pull request may close these issues.
2 participants
@tobybellwood @shreddedbacon