[#69] fix deprecation warning #70
Conversation
| @@ -2,7 +2,7 @@ | |||
| from nox import session | |||
|
|
|||
| PYTHON_VERSIONS = ["3.8", "3.9", "3.10"] | |||
| SPHINX_VERSIONS = ["5.0"] | |||
| SPHINX_VERSIONS = ["5.0", "6.2.1", "7.1.2", "7.2.5"] | |||
There was a problem hiding this comment.
For Sphinx-Needs we have this matrix settings:
Should we use the same versions here as well?
Are there any important changes between 7.1.2 and 7.2.5 which will let our code behave differently?
There was a problem hiding this comment.
First of all: i would be happy if all useblocks provided sphinx extensions could match the same build/testing environment, this would make integration into my used building/testing environment
I choosed 7.1.2 cause this was the last version before the deprecation (introduced with 7.2.0)
It seems to me that with 7.2.5 the App object required by the spinx tests api changed the interface from PathLike Objects to pathlib.Paths. So testing one version AFTER this change and one before seems useful.
|
Hey hello @danwos , is there any chance we get this merged? |
Sphinx in Versions >= 7 migrated to PathLib and generates warnings.
Tests must considers this too