Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namnn/need per id json #960
Namnn/need per id json #960
Changes from 4 commits
eb546d4
600ad3f
0228b24
9a698b0
3de0647
dbb52c0
01320d4
177d3e3
efbe1fa
04f5019
be61481
103cc2f
274842f
1c2af5b
9136af8
26a18b8
ac7c5fe
618e1b0
8802a04
55e0cd3
6462295
dbb9f3f
13c1ca7
86bcfef
f42e9d7
f0ec457
724a367
7e5b7e4
86e343a
30cae4d
41c0368
bb83ac1
c3ff8b6
7ca8d6e
7680146
e969347
3935da6
e518929
8a500e6
786db24
624fd84
ee77802
cbc7bc0
ceae80e
4ee996e
b8fe439
1b79d17
ab99745
b9a0f99
f868ffe
4985e9f
0c8e80f
18cbd4e
305ad77
d9a967d
a9edc4e
bd18a2b
6d50c27
b6819f4
588e4cf
5c30c12
6fd7eba
f85bb09
d474b40
aaf3869
1a288e0
d8013c9
819e716
7aac5d3
41609ff
4d88520
6f5e62e
6ff9b71
d1c46ac
c2ef673
5e8fc85
71988c4
a0c771b
4d06008
a5af64f
9077dca
025cfc5
dafb701
cf47fd4
b84e4cc
ef926b1
0ac8a56
3a10072
49e91cb
43689e5
ba544e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. _build/needs_id
-> Isneeds_id
a builder here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable configs the folder name which is area generate all single file json for every needs-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document first
needs_build_json_per_id
thenneeds_build_json_per_id_path
, asneeds_build_json_per_id_path
is based onneeds_build_json_per_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be only one
needs,json
file?Do all the exports get the same file name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is not necessary for the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file can be a lot more minimal; only include what is absolutely necessary to pass the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not necessary for the test