Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve warning for needextract incompatibility with external needs #1325

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

chrisjsewell
Copy link
Member

closes #677

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.90%. Comparing base (4e10030) to head (2d64c3f).
Report is 72 commits behind head on master.

Files with missing lines Patch % Lines
sphinx_needs/directives/needextract.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   86.87%   87.90%   +1.02%     
==========================================
  Files          56       60       +4     
  Lines        6532     7009     +477     
==========================================
+ Hits         5675     6161     +486     
+ Misses        857      848       -9     
Flag Coverage Δ
pytests 87.90% <0.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit 067009e into master Oct 10, 2024
16 of 17 checks passed
@chrisjsewell chrisjsewell deleted the fix-external-needextract branch October 10, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needextract referencing external needs raises exception.
2 participants