Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Remove target_id core need field #1315

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Oct 3, 2024

This is a duplicate of id_parent (since it is not modified when creating a part from a need)

This is essentially a duplicate of `id_parent`, since it is not modified when creating a part from a need
@chrisjsewell chrisjsewell requested review from danwos and ubmarco October 3, 2024 20:58
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (4e10030) to head (019925c).
Report is 93 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
+ Coverage   86.87%   87.83%   +0.95%     
==========================================
  Files          56       60       +4     
  Lines        6532     7031     +499     
==========================================
+ Hits         5675     6176     +501     
+ Misses        857      855       -2     
Flag Coverage Δ
pytests 87.83% <100.00%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ubmarco ubmarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, the description of the field ID of the data. was not clear anyway.

@chrisjsewell chrisjsewell merged commit 250c58f into master Oct 4, 2024
17 checks passed
@chrisjsewell chrisjsewell deleted the remove_target_id branch October 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants