♻️ Output content in needs.json not description
#1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if there was a legacy reason for this, but it is an unnecessary complication/confusion, to convert between `content` and `description` and breaks the `needs_schema` and defaults.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
+ Coverage 86.87% 87.84% +0.96%
==========================================
Files 56 60 +4
Lines 6532 7033 +501
==========================================
+ Hits 5675 6178 +503
+ Misses 857 855 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ubmarco
approved these changes
Oct 2, 2024
will look at this in a separate PR, about optionally warning on unknown keys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there was a legacy reason for this, but it is an unnecessary complication/confusion,
to convert between
contentanddescriptionand breaks theneeds_schemaand defaults.Note,
needs.jsonimporting logic has been adapted to handle reading of both new and legacy formats