Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add tags option for list2need directive #1296

Merged

Conversation

christopheseyler
Copy link
Contributor

The list2need directive is updated to support tags definition at list level (affecting all items defined in the list)

The PR includes :

  • updated code
  • updated tests
  • updated documentation

The update addresses the issue #1146

@chrisjsewell
Copy link
Member

Cool cheers, I think this sounds good in principle, will get round to a proper review soon

@chrisjsewell chrisjsewell changed the title List2need tags support ✨ add tags option for list2need directive Sep 12, 2024
@chrisjsewell chrisjsewell force-pushed the list2need-tags-support branch 2 times, most recently from 550ff31 to eb29af0 Compare October 4, 2024 21:50
@chrisjsewell chrisjsewell force-pushed the list2need-tags-support branch from eb29af0 to 99d5851 Compare October 4, 2024 23:36
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, hope you don't mind but I made some changes to the PR , to improve/fix the testing 😄

@chrisjsewell chrisjsewell merged commit 1e473e7 into useblocks:master Oct 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants