🐛 Fix plantuml top-level import

`sphinxcontrib.plantuml` is optional, should not not be a top-level import
useblocks · Oct 10, 2024 · d2454a2 · d2454a2
1 parent 2c5fbff
commit d2454a2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/sphinx_needs/directives/needflow/_plantuml.py b/sphinx_needs/directives/needflow/_plantuml.py
@@ -7,9 +7,6 @@
 from docutils import nodes
 from jinja2 import Template
 from sphinx.application import Sphinx
-from sphinxcontrib.plantuml import (
-    generate_name,  # Need for plantuml filename calculation
-)
 
 from sphinx_needs.config import LinkOptionsType, NeedsSphinxConfig
 from sphinx_needs.data import NeedsFlowType, NeedsInfoType, SphinxNeedsData
@@ -244,7 +241,7 @@ def process_needflow_plantuml(
         try:
             if "sphinxcontrib.plantuml" not in app.config.extensions:
                 raise ImportError
-            from sphinxcontrib.plantuml import plantuml
+            from sphinxcontrib.plantuml import generate_name, plantuml
         except ImportError:
             error_node = nodes.error()
             para = nodes.paragraph()

diff --git a/sphinx_needs/directives/needgantt.py b/sphinx_needs/directives/needgantt.py
@@ -8,9 +8,6 @@
 from docutils import nodes
 from docutils.parsers.rst import directives
 from sphinx.application import Sphinx
-from sphinxcontrib.plantuml import (
-    generate_name,  # Need for plantuml filename calculation
-)
 
 from sphinx_needs.config import NeedsSphinxConfig
 from sphinx_needs.data import NeedsGanttType, SphinxNeedsData
@@ -176,7 +173,7 @@ def process_needgantt(
         try:
             if "sphinxcontrib.plantuml" not in app.config.extensions:
                 raise ImportError
-            from sphinxcontrib.plantuml import plantuml
+            from sphinxcontrib.plantuml import generate_name, plantuml
         except ImportError:
             no_plantuml(node)
             continue

diff --git a/sphinx_needs/directives/needsequence.py b/sphinx_needs/directives/needsequence.py
@@ -7,9 +7,6 @@
 from docutils import nodes
 from docutils.parsers.rst import directives
 from sphinx.application import Sphinx
-from sphinxcontrib.plantuml import (
-    generate_name,  # Need for plantuml filename calculation
-)
 
 from sphinx_needs.config import NeedsSphinxConfig
 from sphinx_needs.data import NeedsInfoType, NeedsSequenceType, SphinxNeedsData
@@ -124,7 +121,7 @@ def process_needsequence(
         try:
             if "sphinxcontrib.plantuml" not in app.config.extensions:
                 raise ImportError
-            from sphinxcontrib.plantuml import plantuml
+            from sphinxcontrib.plantuml import generate_name, plantuml
         except ImportError:
             no_plantuml(node)
             continue