increase test coverage

useblocks · Oct 27, 2024 · 4c07eb8 · 4c07eb8
1 parent 63c64f1
commit 4c07eb8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/sphinx_needs/needs.py b/sphinx_needs/needs.py
@@ -429,7 +429,7 @@ def load_config(app: Sphinx, *_args: Any) -> None:
             except KeyError:
                 log_warning(
                     LOGGER,
-                    f"Extra option is a dict, but does not contain a 'name' key: {option}",
+                    f"extra_option is a dict, but does not contain a 'name' key: {option}",
                     "config",
                     None,
                 )
@@ -438,7 +438,7 @@ def load_config(app: Sphinx, *_args: Any) -> None:
         else:
             log_warning(
                 LOGGER,
-                f"Extra option is not a string or dict: {option}",
+                f"extra_option is not a string or dict: {option}",
                 "config",
                 None,
             )

diff --git a/tests/doc_test/extra_options/conf.py b/tests/doc_test/extra_options/conf.py
@@ -4,6 +4,8 @@
     "introduced",
     "updated",
     {"name": "impacts", "description": "What is the impact of this need?"},
+    {},
+    1,
 ]
 
 needs_build_json = True

diff --git a/tests/test_extra_options.py b/tests/test_extra_options.py
@@ -18,7 +18,9 @@ def test_custom_attributes_appear(test_app, snapshot):
 
     warnings = strip_colors(app._warning.getvalue()).splitlines()
     assert warnings == [
-        'WARNING: extra_option "introduced" already registered. [needs.config]'
+        'WARNING: extra_option "introduced" already registered. [needs.config]',
+        "WARNING: extra_option is a dict, but does not contain a 'name' key: {} [needs.config]",
+        "WARNING: extra_option is not a string or dict: 1 [needs.config]",
     ]
 
     needs = json.loads(Path(app.outdir, "needs.json").read_text("utf8"))