bugfix in filter_needs

useblocks · Aug 9, 2023 · 1335b7e · 1335b7e
1 parent c73c44f
commit 1335b7e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/sphinx_needs/filter_common.py b/sphinx_needs/filter_common.py
@@ -309,6 +309,11 @@ def filter_single_need(
             result = bool(eval(filter_compiled, filter_context))
         else:
             result = bool(eval(filter_string, filter_context))
+        if result not in (True, False):
+            # Raises NeedsInvalidFilter if the result is not equal True/False
+            raise NeedsInvalidFilter(
+                f"Error when evaluating filter: expected output to have True/False but got a result <{result}>"
+            )
     except Exception as e:
         raise NeedsInvalidFilter(f"Filter {filter_string} not valid. Error: {e}.")
     return result