This repository has been archived by the owner on May 3, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress attempting to implement issue #12
Currently, I have it passing 172 tests, with 182 failing. It involves a bit of hackery because the tests don't have quite what's needed to test a regex implementation. URI Templates also aren't quite bijective with some ambiguous cases like:
If we get a string like 'a,b,c' we have the following possible ways to match against the uritemplate:
Some of these are more reasonable answers than others, but the fact remains that if you feed these into the expand function, they'll result in the same output. So some sort of rule has to be made to disambiguate in these cases if a regex matcher is going to be complete.