trace: when profiling, dump a sampling trace #671
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we run under the profiling flag, we now collect sampling traces into .urb/put/trace/dump.txt. We take care to format the output in a way that's compatible with flamegraph tooling. Specifically, we avoid writing into the first couple lines of the file, and suffix every trace with a counter (always 1). (See also brendangregg/FlameGraph.) We have not yet cleaned up old code in u3t_samp. Co-authored-by: joemfb <[email protected]>
|
This is sick, love it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we run under the profiling flag (
-P--profile), we now collect sampling traces into.urb/put/trace/dump.txt.We take care to format the output in a way that's compatible with flamegraph tooling. Specifically, we avoid writing into the first couple lines of the file, and suffix every trace with a counter (always 1), to mimic dtrace output.
(See also brendangregg/FlameGraph.)
We have not yet cleaned up old code in
u3t_samp.After running some ship with
--profile, we can use the flamegraph scripts to turn the dump into an svg:If the ship ran
-build-file %/sys/hoon/hoonunder the profiler, the resulting svg might look something like this: