-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in the parsing docs #135
base: master
Are you sure you want to change the base?
Conversation
…ace in `edge` wings
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@tinnus-napbus @sigilante @tamlut-modnys |
I'm not the most familiar with the parsing docs. If something is incorrect it would seem that the right move is to fix it. That being said we should definitely get confirmation from ~tinnus or ~lagrev. Thanks for the PR by the way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of minor changes
If the unit is omitted in explanations or something that should be corrected but I wouldn't worry about dojo outputs. I would assume the dojo examples missing the |
Co-authored-by: tinnus-napbus <[email protected]>
I did some digging and discovered that actually the |
This is a bit off-topic, but it would be cool if the pretty printer could indicate boundaries in the noun where we have to do a type refinement to access the data through faces. Currently it can easily happen that it shows you a noun and it looks like you should be able to access a property with a certain wing, but actually there's a unit in there you need to deal with first, which will also add another limb to your wing. |
Here are corrections to some small errors I found in the parsing docs.
There's another issue I haven't addressed here which I'd like to get feedback on. In an actual
edge
,q.edg
is aunit
, meaning all the references in the docs toq.q.q.edg
(the remaining tape to be parsed) should actually beq.q.u.q.edg
.So my question is, should I go through and update all the references and dojo outputs in these pages to accurately reflect this
u
face in theunit
, or just leave it as it is (which might be more readable)?If we're going to update the faces, it should probably be in this PR, I would think.