fix(upload-client): do not request fileInfo before creating group from uuid #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nd0ut
force-pushed
the
fix/upload-file-group-fix-unnecessary-info-request
branch
4 times, most recently
from
55c94fd to
841f5e8
Compare
…File` instance returned by `uploadFileGroup` method
nd0ut
force-pushed
the
fix/upload-file-group-fix-unnecessary-info-request
branch
from
841f5e8 to
83c0b6c
Compare
LittleCreamSoda
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uploadFileGroupnow won't fetchfileInfobefore creating groups because it's not neededuploadFileGroupwill work withdefault_effects