Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Crossplane-tools version used and remove Get/Set methods on ProviderReferences #29

Closed

Conversation

chaitanyakolluru
Copy link

Description of your changes

This MR updates reference to crossplane-tools to accommodate recent changes to not generate get/set methods on providerRef and removes said methods in all the zz* files. Crossplane-tools MR here.

Fixes #

  • Fixes the issue with using these providers in a Composition Function when updated version of Crossplane-runtime is used.

I have:

  • [x ] Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Changes in the forked branch are applied against a Composition function and it doesn't generate errors based on Get/Set ProviderReference not having the reference under mg's spec.

@chaitanyakolluru chaitanyakolluru changed the title Remove ProviderReference get/set methods on objects crossplane-tools recent change chore: Update Crossplane-tools version used and remove Get/Set methods on ProviderReferences Feb 15, 2024
@haarchri
Copy link
Member

looks like we have one error here:

Error: angryjet: error: error loading packages using pattern ./...: /home/runner/work/provider-vault/provider-vault/apis/ad/v1alpha1/zz_generated.managedlist.go:14:14: cannot use &l.Items[i] (value of type *SecretBackend) as "github.com/crossplane/crossplane-runtime/pkg/resource".Managed value in assignment: *SecretBackend does not implement "github.com/crossplane/crossplane-runtime/pkg/resource".Managed (missing method GetProviderReference)

can you run a make submodules & make generate locally ?

@chaitanyakolluru
Copy link
Author

chaitanyakolluru commented Feb 23, 2024

looks like we have one error here:

Error: angryjet: error: error loading packages using pattern ./...: /home/runner/work/provider-vault/provider-vault/apis/ad/v1alpha1/zz_generated.managedlist.go:14:14: cannot use &l.Items[i] (value of type *SecretBackend) as "github.com/crossplane/crossplane-runtime/pkg/resource".Managed value in assignment: *SecretBackend does not implement "github.com/crossplane/crossplane-runtime/pkg/resource".Managed (missing method GetProviderReference)

can you run a make submodules & make generate locally ?

Needed to update crossplane-runtime to a version that removes the need for Get/SetProviderReference methods in it's Managed interface. Updated to the latest vesion of runtime and it removes the error. Please take a look. Thanks.

Edit: And to clarify, make submodules and generate run successfully locally.

@chaitanyakolluru
Copy link
Author

@haarchri @ulucinar @sergenyalcin

Please take a look at this PR and let me know if it needs any clarification or changes. Thanks.

@jeanduplessis
Copy link
Contributor

@chaitanyakolluru a big update was just merged that already bumps the crossplane-tools library: #46

Considering this and all the conflicts I'll go ahead and close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants