-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Crossplane-tools version used and remove Get/Set methods on ProviderReferences #29
Conversation
looks like we have one error here:
can you run a make submodules & make generate locally ? |
29ac945
to
fb913ee
Compare
Needed to update crossplane-runtime to a version that removes the need for Get/SetProviderReference methods in it's Managed interface. Updated to the latest vesion of runtime and it removes the error. Please take a look. Thanks. Edit: And to clarify, make submodules and generate run successfully locally. |
3d5b13b
to
4e7d1a9
Compare
46fd13c
to
a6cb046
Compare
@haarchri @ulucinar @sergenyalcin Please take a look at this PR and let me know if it needs any clarification or changes. Thanks. |
@chaitanyakolluru a big update was just merged that already bumps the crossplane-tools library: #46 Considering this and all the conflicts I'll go ahead and close this PR for now. |
Description of your changes
This MR updates reference to crossplane-tools to accommodate recent changes to not generate get/set methods on providerRef and removes said methods in all the zz* files. Crossplane-tools MR here.
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Changes in the forked branch are applied against a Composition function and it doesn't generate errors based on Get/Set ProviderReference not having the reference under mg's spec.