Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add approle login example #15

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: add approle login example #15

merged 1 commit into from
Oct 17, 2023

Conversation

swarren83
Copy link
Contributor

Description of your changes

Add approle login example to provider config secrets.yaml.tmpl

Fixes #6

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested in #9

@swarren83
Copy link
Contributor Author

@ulucinar @sergenyalcin May I have a review of this change?

humoflife
humoflife approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@humoflife humoflife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding the Approle example.

@humoflife humoflife merged commit 91014c0 into upbound:main Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humoflife humoflife humoflife approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Authenticate using approle in provider with secure secret_id
2 participants
@swarren83 @humoflife