Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): set go 1.20 also for e2e uptest #16

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Sep 20, 2023

Description of your changes

  # vault_mount.vault-creds-kv1 must be replaced
-/+ resource "vault_mount" "vault-creds-kv1" {
      ~ accessor                     = "kv_425e40b5" -> (known after apply)
      - allowed_managed_keys         = [] -> null
      ~ audit_non_hmac_request_keys  = [] -> (known after apply)
      ~ audit_non_hmac_response_keys = [] -> (known after apply)
      ~ default_lease_ttl_seconds    = 0 -> (known after apply)
      ~ id                           = "kvv1" -> (known after apply)
      - local                        = false -> null
      ~ max_lease_ttl_seconds        = 0 -> (known after apply)
      ~ seal_wrap                    = false -> (known after apply)
      ~ type                         = "kv" -> "kv-v1" # forces replacement

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@haarchri
Copy link
Member Author

/test-examples="examples/mount/mount-generic-secrets.yaml,examples/mount/mount-kv-v1.yaml,examples/mount/mount-kv-v2.yaml"

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haarchri haarchri merged commit 9bea571 into main Sep 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants