Skip to content

Commit

Permalink
feat(go): set go 1.20 also for e2e uptest
Browse files Browse the repository at this point in the history
Signed-off-by: Christopher Haar <[email protected]>
  • Loading branch information
haarchri committed Sep 20, 2023
1 parent cfe44e6 commit a968e24
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

env:
# Common versions
GO_VERSION: '1.19'
GO_VERSION: '1.20'
GOLANGCI_VERSION: 'v1.53.3'
DOCKER_BUILDX_VERSION: 'v0.8.2'

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
jobs:
e2e:
uses: upbound/uptest/.github/workflows/pr-comment-trigger.yml@main
with:
go-version: '1.20'
secrets:
UPTEST_CLOUD_CREDENTIALS: "not used"
UPTEST_DATASOURCE: ${{ secrets.UPTEST_DATASOURCE }}
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ NPROCS ?= 1
# to half the number of CPU cores.
GO_TEST_PARALLEL := $(shell echo $$(( $(NPROCS) / 2 )))

GO_REQUIRED_VERSION ?= 1.19
GO_REQUIRED_VERSION ?= 1.20
GO_STATIC_PACKAGES = $(GO_PROJECT)/cmd/provider $(GO_PROJECT)/cmd/generator
GO_LDFLAGS += -X $(GO_PROJECT)/internal/version.Version=$(VERSION)
GO_SUBDIRS += cmd internal apis
Expand Down
2 changes: 1 addition & 1 deletion examples/auth/authbackend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: github-generic-auth-backend
spec:
forProvider:
description: "GitHub generic auth backend for UXP manageed Vault"
description: "GitHub generic auth backend for UXP managed Vault"
type: "github"
providerConfigRef:
name: vault-provider-config
2 changes: 1 addition & 1 deletion examples/githubauthbackend/githubauthbackend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ metadata:
name: github-specific-auth-backend
spec:
forProvider:
description: "GitHub specific auth backend for UXP manageed Vault"
description: "GitHub specific auth backend for UXP managed Vault"
path: "auth/github-specific"
organization: default-org-test
providerConfigRef:
Expand Down
2 changes: 1 addition & 1 deletion examples/githubteam/githubteam.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ metadata:
name: github-team
spec:
forProvider:
description: "GitHub generic auth backend for UXP manageed Vault"
description: "GitHub generic auth backend for UXP managed Vault"
type: "github"
providerConfigRef:
name: vault-provider-config

0 comments on commit a968e24

Please sign in to comment.