Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file_path_format::detect #37

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Remove file_path_format::detect #37

merged 1 commit into from
Jan 15, 2024

Conversation

rmisev
Copy link
Member

@rmisev rmisev commented Jan 14, 2024

Use file_path_format::native as default in the url_from_file_path function.

The path format detection algorithm was simple: if the first path character is /, then it is POSIX format, otherwise - Windows.
But in some cases it is ambiguous, e.g. path //h\sn\p is recognized as POSIX path, but it can also be Windows UNC path, because / is allowed as directory separator in Windows paths.

Use file_path_format::native as default in the url_from_file_path
function.
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7842b29) 99.74% compared to head (c3026b1) 99.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   99.74%   99.74%   -0.01%     
==========================================
  Files          16       16              
  Lines        2326     2321       -5     
==========================================
- Hits         2320     2315       -5     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmisev rmisev merged commit a5426ca into main Jan 15, 2024
22 checks passed
@rmisev rmisev deleted the rem-detect branch January 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant