Add and use the detail::is_posix_slash function

upa-url · Aug 25, 2024 · a219398 · a219398
1 parent efabe2e
commit a219398
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/include/upa/url.h b/include/upa/url.h
@@ -983,6 +983,11 @@ constexpr bool is_slash(CharT ch) noexcept {
     return ch == '/' || ch == '\\';
 }
 
+template <typename CharT>
+constexpr bool is_posix_slash(CharT ch) noexcept {
+    return ch == '/';
+}
+
 template <typename CharT>
 constexpr bool is_windows_slash(CharT ch) noexcept {
     return ch == '\\' || ch == '/';
@@ -3180,9 +3185,9 @@ inline url url_from_file_path(StrT&& str, file_path_format format = file_path_fo
     std::string str_url("file://");
 
     if (format == file_path_format::posix) {
-        if (*first != '/')
+        if (!detail::is_posix_slash(*first))
             throw url_error(validation_errc::file_unsupported_path, "Non-absolute POSIX path");
-        if (detail::has_dot_dot_segment(start_of_check, last, [](CharT c) { return c == '/'; }))
+        if (detail::has_dot_dot_segment(start_of_check, last, detail::is_posix_slash<CharT>))
             throw url_error(validation_errc::file_unsupported_path, "Unsupported file path");
         // Absolute POSIX path
         no_encode_set = &posix_path_no_encode_set;