Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(animation): update link to motion one #871

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dwightjack
Copy link
Contributor

In the animation page, we link to a deprecated version of Motion One for Vue. The new implementation is Oku Motion and is still based on Motion One.

This PR fixes the link and refactors the related paragraph. I am not sure how to update the Stackblitz demo, but the only changes needed are:

  1. Switch the packages:
npm remove motion
npm install @oku-ui/motion --save
  1. replace motion/vue with @oku-ui/motion in App.vue

@zernonia
Copy link
Member

Thanks for the PR @dwightjack ! Can you help update the Stackblitz demo too by forking demo? And make sure everything in demo still works? 😁

@dwightjack
Copy link
Contributor Author

Thanks for the PR @dwightjack ! Can you help update the Stackblitz demo too by forking demo? And make sure everything in demo still works? 😁

@zernonia Sure. I pushed a commit with the forked demo.

@zernonia
Copy link
Member

Noticed there's some warning after changing to Oku Motion. Seems like not affecting the animation. Perhaps we should logged issue or maybe adapt to the changes? 😁

image

@dwightjack
Copy link
Contributor Author

I didn't notice them! It seems there is an open issue on Oku Motion about those warnings: oku-ui/motion#36.

Do you think we should wait until the issue gets fixed (these changes aren't a high priority)?

@zernonia
Copy link
Member

Yeah I suggest let's wait a see 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants