Partial fix for Windows build regression

On Windows builds, there was an issue with dependencies not copying and therefore not linking when building native modules, this is now fixed.
unofficial-rev-port · Jul 1, 2024 · 4b14281 · 4b14281
1 parent 7526628
commit 4b14281
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -38,6 +38,15 @@
                 '<(module_root_dir)/externalCompileTimeDeps/wpiHal.lib',
                 '<(module_root_dir)/externalCompileTimeDeps/wpiutil.lib',
             ],
+            'copies': [{
+                'destination': './build/Release',
+                'files': [
+                    # These files were placed in the prebuilds folder by download-CanBridge.mjs
+                    '<(module_root_dir)/prebuilds/win32-x64/CANBridge.dll',
+                    '<(module_root_dir)/prebuilds/win32-x64/wpiHal.dll',
+                    '<(module_root_dir)/prebuilds/win32-x64/wpiutil.dll',
+                ]
+            }],
         }],
         ['OS=="linux"', {
             'libraries': [

diff --git a/package.json b/package.json
@@ -24,9 +24,9 @@
         "typescript": "^5.0.2"
     },
     "scripts": {
-        "install": "node-gyp-build \"node scripts/download-CanBridge.mjs\"",
+        "install": "node scripts/download-CanBridge.mjs && node-gyp rebuild",
         "prepublishOnly": "node scripts/download-CanBridge.mjs && tsc && prebuildify --napi",
-        "pretest": "node-gyp-build && tsc",
+        "pretest": "node-gyp rebuild && tsc",
         "test": "node --napi-modules test/test_binding.js"
     },
     "engines": {