feat(networks,governance): add Linea to cross chain governance #14597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some verification calls have failed :
Some additonal warnings :
|
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
It happens that Linea was still on v13... |
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
2 similar comments
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
|
need to be rebased once #14636 is merged |
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
1 similar comment
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
1 similar comment
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
julien51
reviewed
Sep 24, 2024
clemsos
commented
Sep 25, 2024
packages/networks/src/networks/linea.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
|
|
fixed once #14665 merged |
packages/networks/src/networks/linea.tsThe setup is successful :
Some additonal warnings :
|
|
ok, looking good! I think we just need to verify the delayMod ? |
yes asking again to the Gnosis Guild team here gnosisguild/zodiac-modifier-delay#31 |
packages/networks/src/networks/linea.tsThe setup is successful :
Some additonal warnings :
|
clemsos
force-pushed
the
linea-cross-gov
branch
from
29e39fe to
3f8f4e7
Compare
|
ok the delay module is now verified, thanks to @auryn-macmillan https://lineascan.build/address/0xd54895B1121A2eE3f37b502F507631FA1331BED6#code |
packages/networks/src/networks/linea.tsThe setup is successful :
Some additonal warnings :
|
packages/networks/src/networks/linea.tsThe setup is successful :
Some additonal warnings :
|
julien51
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for Linea to the cross-chain governance process.
TODO:
governanceBridgesection to the network packagedeploy safe delay module master copiessupport linea in Gnosis Guild core lib Add support for Linea gnosisguild/zodiac#163governanceBridgesection with the deployed modules addressIssues
Fixes #
Refs #13463
Checklist:
Release Note Draft Snippet