Upgrade api calls to work with OpenShift 4.x #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
singularo
commented
Apr 12, 2022
singularo
commented
- Imagestream creation working.
singularo
changed the title
|
Tests run passing again. Ignoring the old ClientTest.php as it requires a running shepherd to curl against. Would prefer to mock the guzzle responses, but its not been working for ages, so... ignore for now. |
pingers
reviewed
May 17, 2022
| @@ -1497,7 +1456,7 @@ public function updateReplicationControllers($name, $label = NULL, $replica_coun | |||
|
|
|||
| $repControllers = $this->getReplicationControllers($name, $label); | |||
| if ($replica_count === NULL) { | |||
| // @todo - err what ? | |||
| // @todo err what ? | |||
|
While batch api v1beta works, we should move to stable. |
|
Until shepherd is merged, we want to keep 4.x separate from 3.x... so lets leave this branch open for now |
…ervice-accounts sapp 2505 - multiple service accounts
* Add support for updating storage size. * Add missing token var, comments.
* Add labels functionality to route object. * Remove unneeded label code, add missing annotation class, update test. * Wrong one. * Dangling comma. * Remove duplicated annotations and put all in the ObjectBase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.