Fix/hfc opti reg prob #2588
Merged
Fix/hfc opti reg prob #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an 1 for optimized historical forecasts
dennisbader
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Thanks @madtoinou, looks good to me. Just a minor suggestion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2588 +/- ##
==========================================
- Coverage 94.14% 94.09% -0.06%
==========================================
Files 139 139
Lines 14882 14884 +2
==========================================
- Hits 14011 14005 -6
- Misses 871 879 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes #2461.
Summary
Thanks to #2534, the reshaping of the features logic was fixed. This PR just makes sure an exception is raised when trying to use
num_samples > 1with a deterministic regression model and the optimized historical forecasts (which does not call theForecastingModel.predict()method, where some sanity checks are implemented).