Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upper cap pytorch lightning for ckpt symlink fix #2136

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Dec 29, 2023

see #2133

Summary

  • fixes currently failing unit tests
  • sets an upper cap on pytorch lightning <=2.1.2 to fix the checkpoint symlink issue.
  • pytorch lightning already reverted these changes here. Will relax the cap once they release the new version

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab3d77a) 93.92% compared to head (4567521) 93.91%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2136      +/-   ##
==========================================
- Coverage   93.92%   93.91%   -0.01%     
==========================================
  Files         135      135              
  Lines       13335    13321      -14     
==========================================
- Hits        12525    12511      -14     
  Misses        810      810              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 6082f62 into master Dec 29, 2023
9 checks passed
@dennisbader dennisbader deleted the fix/ptl_ckpt_symlink branch December 29, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants