-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/no lambda function in add_encoders #1957
Conversation
…lem when saving the model (pickling)
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1957 +/- ##
==========================================
- Coverage 93.84% 93.84% -0.01%
==========================================
Files 132 132
Lines 12731 12721 -10
==========================================
- Hits 11948 11938 -10
Misses 783 783
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @madtoinou 🚀
Only thing left is to update the add_encoders
model docs that still use the lambda functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @madtoinou 🚀
Last thing to do is add it to the changelog, as a breaking change).
Fixes #1843.
Summary
add_encoders
parameter so that model pickling works as intended when saving the model.Other Information