Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to version 8.45 #3

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

nelsongillo
Copy link

Upgrading to version 8.45, completing #2

@razvand razvand added the enhancement New feature or request label Oct 23, 2022
@razvand razvand self-requested a review October 23, 2022 12:15
@razvand
Copy link

razvand commented Oct 23, 2022

@EinzigartigerName , how did you test it?

@razvand razvand linked an issue Oct 23, 2022 that may be closed by this pull request
@nelsongillo
Copy link
Author

Build successful on x86_64, runs in linuxu and kvm.

@razvand
Copy link

razvand commented Oct 23, 2022

Build successful on x86_64, runs in linuxu and kvm.

How did you build it, what application did you use, did you make calls to functions exposed by the library?

@nelsongillo
Copy link
Author

nelsongillo commented Oct 23, 2022

Extending app-helloworld with minimal example using pcre_compile and pcre_exec: build and run successful

Sample Code:

re = pcre_compile (regex, 0, &error, &erroffset, 0);
if (!re)
{
    printf("pcre_compile failed (offset: %d), %s\n", erroffset, error);
    return -1;
}

unsigned int offset = 0;
unsigned int len    = strlen(str);
rc = pcre_exec(re, 0, str, len, offset, 0, ovector, OVECTOR_SIZE);

if (rc == 1) {
    printf("Valid!\n");
} else {
	printf("Not Valid!\n");
}

@razvand
Copy link

razvand commented Oct 23, 2022

@EinzigartigerName , 20 points added. Please see the comments for other points.

Copy link

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @EinzigartigerName . Please sign off the commit. Also mention, as part of the commit, details about testing it, ideally a link to a test file.

Built and minimal function test of pcre_compile and pcre_exec.
Sample program: https://gist.github.com/einzigartigerName/71b4be3b450e7ff5102d4b450a03c5d4

Signed-off-by: Nelson Gillo <[email protected]>
@razvand
Copy link

razvand commented Oct 23, 2022

@EinzigartigerName , this doesn't work for me. I'm using the latest Unikraft version and I get the following error when running the building and running a Unikernel image using minimal_pcre_test.c:

razvan@yggdrasil:~/.../unikraft-my/apps/app-helloworld$ qemu-system-x86_64 -enable-kvm -cpu host -nographic -kernel build/app-helloworld_kvm-x86_64
Powered by
o.   .o       _ _               __ _
Oo   Oo  ___ (_) | __ __  __ _ ' _) :_
oO   oO ' _ `| | |/ /  _)' _` | |_|  _)
oOo oOO| | | | |   (| | | (_) |  _) :_
 OoOoO ._, ._:_:_,\_._,  .__,_:_, \___)
                 Phoebe 0.10.0~9bf6e633
[    0.112019] CRIT: [libkvmplat] <traps.c @   84> Unhandled Trap 13 (general protection), error code=0x0
[    0.116644] CRIT: [libkvmplat] <trace.c @   41> RIP: 000000000011ad78 CS: 0008
[    0.119501] CRIT: [libkvmplat] <trace.c @   43> RSP: 0000000007fde9f8 SS: 0010 EFLAGS: 00010212
[    0.122733] CRIT: [libkvmplat] <trace.c @   45> RAX: 00000000001364f8 RBX: 0000000000000061 RCX: 0000000000000001
[    0.126523] CRIT: [libkvmplat] <trace.c @   47> RDX: 0000000000000061 RSI: 00000000001364f9 RDI: 0000000000000000
[    0.130101] CRIT: [libkvmplat] <trace.c @   49> RBP: 0000000007fdebf8 R08: 0000000000000000 R09: 0000000000000000
[    0.134152] CRIT: [libkvmplat] <trace.c @   51> R10: 0000000000000000 R11: 0000000007fdeb88 R12: 0000000007fded18
[    0.138206] CRIT: [libkvmplat] <trace.c @   53> R13: 00000000001364f9 R14: 0000000000000000 R15: 0000000007fdef1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Update library version to 8.45
2 participants