-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to version 8.45 #3
base: staging
Are you sure you want to change the base?
Conversation
@EinzigartigerName , how did you test it? |
Build successful on x86_64, runs in |
How did you build it, what application did you use, did you make calls to functions exposed by the library? |
Extending Sample Code: re = pcre_compile (regex, 0, &error, &erroffset, 0);
if (!re)
{
printf("pcre_compile failed (offset: %d), %s\n", erroffset, error);
return -1;
}
unsigned int offset = 0;
unsigned int len = strlen(str);
rc = pcre_exec(re, 0, str, len, offset, 0, ovector, OVECTOR_SIZE);
if (rc == 1) {
printf("Valid!\n");
} else {
printf("Not Valid!\n");
} |
@EinzigartigerName , 20 points added. Please see the comments for other points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @EinzigartigerName . Please sign off the commit. Also mention, as part of the commit, details about testing it, ideally a link to a test file.
Built and minimal function test of pcre_compile and pcre_exec. Sample program: https://gist.github.com/einzigartigerName/71b4be3b450e7ff5102d4b450a03c5d4 Signed-off-by: Nelson Gillo <[email protected]>
@EinzigartigerName , this doesn't work for me. I'm using the latest Unikraft version and I get the following error when running the building and running a Unikernel image using
|
Upgrading to version 8.45, completing #2