Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental to datetime's bench features #5888

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Dec 11, 2024

Both benchmark suites in the datetime component use the CompositeFieldSetSerde which is under the experimental feature. As a result, running cargo bench -F bench --manifest-path components/datetime/Cargo.toml will not run any benchmark. This currently causes CI to fail on the main branch (e.g. https://github.com/unicode-org/icu4x/actions/runs/12279258426/job/34262931118).

This PR adds the experimental feature to the bench feature. Alternatively, the workflow could specify additional features to pass to a component's benchmarks. However, when running the benchmarks locally, one would always need to specify the experimental feature.

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

@sffc sffc merged commit d2a4937 into unicode-org:main Dec 12, 2024
28 checks passed
@sffc
Copy link
Member

sffc commented Dec 12, 2024

Thank you!

@Nerixyz Nerixyz deleted the fix/bench-datetime branch December 13, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants