Add experimental
to datetime's bench
features
#5888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both benchmark suites in the
datetime
component use theCompositeFieldSetSerde
which is under theexperimental
feature. As a result, runningcargo bench -F bench --manifest-path components/datetime/Cargo.toml
will not run any benchmark. This currently causes CI to fail on the main branch (e.g. https://github.com/unicode-org/icu4x/actions/runs/12279258426/job/34262931118).This PR adds the
experimental
feature to thebench
feature. Alternatively, the workflow could specify additional features to pass to a component's benchmarks. However, when running the benchmarks locally, one would always need to specify theexperimental
feature.