Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move numbering systems field over to DecimalSymbolsStrs #5830

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

Manishearth
Copy link
Member

Depends on #5822

Minor win:

Before: decimal/symbols@2, <total>, 2740B, 1368B, 49 unique payloads
After:  decimal/symbols@2, <total>, 2657B, 1285B, 49 unique payloads

And an 8 byte win on FDF stack size.

sffc
sffc previously approved these changes Nov 15, 2024
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stack size win is my main motivation

@Manishearth
Copy link
Member Author

@sffc Thought: do you think we can get away with Index8 for DecimalSymbolStrs? Each one of its entries is at worst 3 characters (when it contains bidi format characters), and then there's the ascii numbering system, at worst 8 bytes.

(8 numsys bytes) + (3 chars) * (2-4 bytes per char) * (6 fields) is 44-80, which is still well in range for a u8.

@sffc
Copy link
Member

sffc commented Nov 15, 2024

Yes we should definitely use Index8

Copy link

dpulls bot commented Nov 15, 2024

🎉 All dependencies have been resolved !

@Manishearth
Copy link
Member Author

Before: decimal/symbols@2, <total>, 2657B, 1285B, 49 unique payloads
After:  decimal/symbols@2, <total>, 2363B, 991B, 49 unique payloads

For Index8.

@Manishearth Manishearth merged commit 9e9822b into unicode-org:main Nov 15, 2024
28 checks passed
@Manishearth Manishearth deleted the str-decimaldigits branch November 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants