-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move numbering systems field over to DecimalSymbolsStrs #5830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stack size win is my main motivation
@sffc Thought: do you think we can get away with Index8 for DecimalSymbolStrs? Each one of its entries is at worst 3 characters (when it contains bidi format characters), and then there's the ascii numbering system, at worst 8 bytes.
|
19cce94
to
564cf05
Compare
Yes we should definitely use Index8 |
564cf05
to
d5e9413
Compare
🎉 All dependencies have been resolved ! |
d5e9413
to
9ee3b13
Compare
For Index8. |
dd23f44
to
872673a
Compare
Depends on #5822
Minor win:
And an 8 byte win on FDF stack size.