Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement without_descendants and without_ancestors in datagen #4846

Merged
merged 29 commits into from
Apr 30, 2024
Merged

Implement without_descendants and without_ancestors in datagen #4846

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c18bb78
Start adding without_ancestors (#4629)
sffc Apr 24, 2024
5c5b990
Mostly working
sffc Apr 25, 2024
8cb704c
Add test for without_ancestors
sffc Apr 25, 2024
1c99e75
fmt
sffc Apr 25, 2024
c0d9149
clippy
sffc Apr 25, 2024
9e76071
Add collation special case for backwards compatibility
sffc Apr 25, 2024
78c923b
Special case for --locales full; fixes
sffc Apr 25, 2024
a36b095
Generalize special case (also impacts transliterator)
sffc Apr 25, 2024
4b2362e
Return to the old way of handling --locales full: needs to work with …
sffc Apr 25, 2024
fc27d6c
Always include variants of und for region fallback
sffc Apr 25, 2024
ad6f135
Inline langid_families
sffc Apr 25, 2024
ac0b97d
de-AT-u-co-phonebk is now included to prevent fallback to de-AT
sffc Apr 25, 2024
5eb0f78
fmt/rename
sffc Apr 25, 2024
0600a81
Undo addition of either dep
sffc Apr 25, 2024
dd78d71
Merge branch 'main' into without-ancestors
sffc Apr 29, 2024
d980270
Define precedence ordering for LocaleFamily; refactor to support it
sffc Apr 29, 2024
8d18020
Switch data structures to use less mutation
sffc Apr 30, 2024
04b22d0
Even less mutation
sffc Apr 30, 2024
23810a7
Even less mutation
sffc Apr 30, 2024
f955ef1
docs, clippy
sffc Apr 30, 2024
5a4b115
Cleanup
sffc Apr 30, 2024
2960378
Fix
sffc Apr 30, 2024
85380a0
Clippy
sffc Apr 30, 2024
48a1355
Fix
sffc Apr 30, 2024
3f94341
Update provider/datagen/src/driver.rs
sffc Apr 30, 2024
c7b7924
inner -> parts
sffc Apr 30, 2024
7a6ed81
langids
sffc Apr 30, 2024
bddaa9b
comment about false
sffc Apr 30, 2024
2b9638b
Deduplicate candidate langids
sffc Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions provider/baked/collator/data/macros/collator_meta_v1.rs.data
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion provider/blob/src/export/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
//! DatagenDriver::new()
//! .with_keys([icu_provider::hello_world::HelloWorldV1Marker::KEY])
//! .with_all_locales()
//! .export(&DatagenProvider::new_latest_tested(), exporter)
//! .export(&icu_provider::hello_world::HelloWorldProvider, exporter)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't impact behavior; it just makes it so that this crate doesn't need to depend on the provider feature of icu_datagen

//! .unwrap();
//!
//! // communicate the blob to the client application (network, disk, etc.)
Expand Down
2 changes: 1 addition & 1 deletion provider/blob/tests/test_versions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ fn run_driver(exporter: BlobExporter) -> Result<(), DataError> {
DatagenDriver::new()
.with_keys([icu_provider::hello_world::HelloWorldV1Marker::KEY])
.with_locales_and_fallback([LocaleFamily::full()], Default::default())
.export(&DatagenProvider::new_custom(), exporter)
.export(&icu_provider::hello_world::HelloWorldProvider, exporter)
robertbastian marked this conversation as resolved.
Show resolved Hide resolved
}

fn check_hello_world(blob_provider: impl DataProvider<HelloWorldV1Marker>) {
Expand Down
Loading
Loading